Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration sync test #1681

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Remove integration sync test #1681

merged 2 commits into from
Nov 13, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Nov 12, 2019

Description

Remove the test that checks whether or not we can sync with integration. This test is frequently broken as we do not update integration nightly, and we make breaking changes frequently.

Tested

Not tested

Other changes

None

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #1681 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   74.42%   74.38%   -0.04%     
==========================================
  Files         279      279              
  Lines        7573     7566       -7     
  Branches      949      663     -286     
==========================================
- Hits         5636     5628       -8     
- Misses       1823     1824       +1     
  Partials      114      114
Flag Coverage Δ
#mobile 74.38% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/localCurrency/selectors.ts 65.51% <0%> (-9.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb56cf...3b9138a. Read the comment docs.

@nategraf nategraf assigned asaj and unassigned nategraf Nov 13, 2019
@timmoreton timmoreton merged commit 9f4c083 into master Nov 13, 2019
@timmoreton timmoreton deleted the asaj/e2e-integration-sync branch November 13, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants